Skip to content

Fix applist #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 8, 2024
Merged

Fix applist #20

merged 25 commits into from
Jun 8, 2024

Conversation

wiiznokes
Copy link
Contributor

@wiiznokes wiiznokes commented Jun 8, 2024 •
edited
Loading

Contains some enhancement from #19, but without the exec stuff

  • return Vec for field separated by ;
  • fix get_entry_score logic, and use separate value for field separated by ;
  • fix match_entry_from_id. After some iteration, I think this impl fixes most case, at least all that were reported.

Sorry for the messed up history

oknozor and others added 19 commits June 6, 2024 00:02
@oknozor @wiiznokes
feat: add launch function for desktop entries
58c11b9
@oknozor @wiiznokes
feat: launch desktop entries via dbus
2b0fb2d
@oknozor @wiiznokes
chore: add MPD-2.0 license
62ba13c
@oknozor @wiiznokes
refactor: use compile time env var for vulkan icd base path
0fab5e5
@oknozor @wiiznokes
refactor: remove prefer_non_default arg gpu and use desktop entry att…
53e82a1 
…ribute instead
@oknozor @wiiznokes
fix: fork process instead of spawning with std::process::Command
caa1db5
@wiiznokes
hello
c69c7bd
@wiiznokes
fix compile
477ce38
@wiiznokes
upgrade the behavior of get_entry_score
dc493c7
@wiiznokes
add 2 tests
ec76f18
@wiiznokes
add launch_with_uris variant
0cdb67f
@wiiznokes
change export, remove test, add licence on top
21f86a0
@wiiznokes
add actions support
e8459b7
@wiiznokes
add not_show_in, directly return a Vec when field is a list
2eaacb8
@wiiznokes
add current_desktop, Eq and Hash
7d349d9
@wiiznokes
add logs, include name and exec, lower min score
5c24bcb
@wiiznokes
fix log
fc93a84
@wiiznokes
remove exec + lower min score + remove exec
8de5926
@wiiznokes
remove some files specific to exec
1ee14ea
@wiiznokes wiiznokes mentioned this pull request Jun 8, 2024
Merged
@wiiznokes wiiznokes marked this pull request as ready for review June 8, 2024 19:03
@wiiznokes wiiznokes mentioned this pull request Jun 8, 2024
Merged
@mmstick
Copy link
Member

mmstick commented Jun 8, 2024

Firefox is fixed

@mmstick mmstick merged commit a05abe5 into pop-os:main Jun 8, 2024
@wiiznokes wiiznokes deleted the fix-applist branch June 8, 2024 21:50
@bGVia3VjaGVu
Copy link

split_terminator should be used instead of split, especially since a Vec is returned. I prefer returning iterators, since application may only be interested in the first category and it's not hard to call map and collect.

@wiiznokes
Copy link
Contributor Author

split_terminator should be used instead of split, especially since a Vec is returned. I prefer returning iterators, since application may only be interested in the first category and it's not hard to call map and collect.

I agree, an iterator would be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmstick mmstick mmstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiiznokes @mmstick @bGVia3VjaGVu @oknozor